Bug 138 - groff detection in configure broken
Summary: groff detection in configure broken
Status: CLOSED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: docs (show other bugs)
Version: 2.0
Hardware: PC Linux
: low major
Assignee: Steve Singer
URL:
Depends on:
Blocks:
 
Reported: 2010-06-28 09:18 UTC by Peter Eisentraut
Modified: 2010-08-23 10:14 UTC (History)
1 user (show)

See Also:

Attachments
patch to define GROFF (1013 bytes, patch)
2010-07-19 09:04 UTC, Steve Singer 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Eisentraut 2010-06-28 09:18:56 UTC 
In 2.0.4, @GROFF@ in Makefile.global.in is not substituted, because nothing in configure defines it.  As a consequence, the build of the documentation fails.  configure contains an unexpanded macro call SLON_AC_PROG_GROFF, which looks like a botched attempt to do groff detection.
Comment 1 Steve Singer 2010-07-19 09:04:46 UTC 
Created attachment 51 [details]
patch to define GROFF

This patch should define GROFF
Comment 2 Christopher Browne 2010-08-16 08:54:05 UTC 
Looks good to me.
Comment 3 Christopher Browne 2010-08-16 08:54:35 UTC 
FYI, that seems also to apply to HEAD.
Comment 4 Steve Singer 2010-08-23 10:03:20 UTC 
Added to REL_2_0_STABLE and master
b4f202e3f67e66a311a4a32c6392bb2be3bc05a2
9dbcd68c88c0add15e242a4f091d2b585bdbae58
Comment 5 Christopher Browne 2010-08-23 10:14:17 UTC 
I see that in the 2.0 release notes.