Summary: | Command line argument to only echo DDL on failure | ||
---|---|---|---|
Product: | Slony-I | Reporter: | Stuart Bishop <stuart> |
Component: | slonik | Assignee: | Slony Bugs List <slony1-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | slony1-bugs |
Priority: | low | ||
Version: | devel | ||
Hardware: | PC | ||
OS: | Linux |
Description
Stuart Bishop
2010-08-25 20:12:45 UTC
I wonder if this suggests having a 'status' that can be set. ----------------------- cluster name = foo; node 1 admin conninfo='something'; node 2 admin conninfo='something else'; output ddl; execute script (stuff...); output nothing; execute script (more stuff...) output all; execute script (still more stuff...) ----------------------- Adding a keyword or three like this is not terribly difficult; the question is of what they should control. If we have an answer that's relatively simple and which seems elegant, then it's likely a good answer. The above isn't quite that. Actually, I suggest another approach... When I modified DDL script processing, the printf() statements that you're observing were really part of my debugging infrastructure, when I was verifying that all was being handled properly. It may be readily argued that these statements should simply be removed. To that end, I have a branch that makes just such a change... https://github.com/cbbrowne/slony1-engine/tree/bug152 Minor patch involved: https://github.com/cbbrowne/slony1-engine/commit/10dd7d4f44a17211f0aa4885c3128c5edb1f22d5 This change looks fine to commit against master. |