Bug 127 - sync events are not generated on nodes that are not a set origin
Summary: sync events are not generated on nodes that are not a set origin
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: slon (show other bugs)
Version: 1.2
Hardware: All All
: high normal
Assignee: Steve Singer
URL:
Depends on:
Blocks: 92
  Show dependency tree
 
Reported: 2010-05-21 11:11 UTC by Steve Singer
Modified: 2010-08-11 14:03 UTC (History)
2 users (show)

See Also:


Attachments
patch against 2.0 to restore sync generating on all nodes (2.88 KB, patch)
2010-07-13 10:25 UTC, Steve Singer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Singer 2010-05-21 11:11:16 UTC
See http://lists.slony.info/pipermail/slony1-bugs/2010-May/000495.html

Basically no sync events (other than when slon starts) are being generated on nodes that are not origins for any set.  This makes the sl_status table seem out of date.

This change was checked in on Mar 14 2007.

Current thinking is that this is actually a bug.
Comment 1 Devin Ben-Hur 2010-06-28 12:09:35 UTC
We noticed this behavior change when moving from 1.2x to 2.0x as it made some health monitors conducting sl_status lag-time polling uninformative on non-origin nodes.

In the archives, I notice at least one other person encountering the problem too http://permalink.gmane.org/gmane.comp.db.postgresql.slony1.general/9029

This bug is marked as applying to v1.2, but the behavior effects v2.0 as well and gives non-origin nodes the appearance of accumulating tremendous replication lag.
Comment 2 Steve Singer 2010-07-13 10:25:23 UTC
Created attachment 49 [details]
patch against 2.0 to restore sync generating on all nodes

This patch reverts the checkin (updated to the 2.0 stream) the original commit that disabled generating sync messages on leaf nodes.
Comment 3 Christopher Browne 2010-08-11 09:01:39 UTC
(In reply to comment #2)
> Created an attachment (id=49) [details]
> patch against 2.0 to restore sync generating on all nodes
> 
> This patch reverts the checkin (updated to the 2.0 stream) the original commit
> that disabled generating sync messages on leaf nodes.

The code is a bit more complex than I'd have expected, but this looks reasonable to me.  (I guess it was more complex to suppress the events than I'd expected!)
Comment 4 Steve Singer 2010-08-11 14:03:25 UTC
Committed to master and REL_2_0_STABLE
fe2c2040fcc454fef9c4da85a518c08840b49c2f
572581c4d80fd95206aed1910fb22d7119aa4be4

Note this has been left as is on the 1.2 branch